Re: [boost] [system] WinCE patch for FormatMessageA

From: Anthony Williams (anthony_w.geo_at_[hidden])
Date: 2007-11-02 09:06:00

Beman Dawes <bdawes_at_[hidden]> writes:

> Beman Dawes wrote:
>> David Deakins wrote:
>>> Windows CE does not supply the ANSI version of FormatMessage (only 
>>> FormatMessageW).  The attached patch substitutes FormatMessageW-based 
>>> code in this case.
>> 
>> I've applied the patch, but am concerned about the name of the 
>> BOOST_NO_ANSI_APIS macro.
>> 
>> For clarity, I'd prefer the name indicate that this is a Windows 
>> workaround. Perhaps BOOST_NO_WINDOWS_ANSI_API?
>> 
>> Is this something used by other libraries? If it is specific to 
>> Boost.System, I'd prefer BOOST_SYSTEM_NO_WINDOWS_ANSI_API.
>
> Hum... Wouldn't it be better to use the _WIN32_WCE predefined macro? 
> That way the user doesn't have to configure anything.

BOOST_NO_ANSI_APIS is a boost config macro from
boost/config/platform/win32.hpp

It is used by the boost.thread as well as Boost.System, and maybe others.

Anthony
-- 
Anthony Williams
Just Software Solutions Ltd - http://www.justsoftwaresolutions.co.uk
Registered in England, Company Number 5478976.
Registered Office: 15 Carrallack Mews, St Just, Cornwall, TR19 7UL