Re: [boost] [ptr_container] trunk has problems with multiple definitions of xml_names with multiple TUs

From: Michael Marcin (mmarcin_at_[hidden])
Date: 2007-11-07 15:14:20

Martin Bonner wrote:
> Thorsten Ottosen wrote:
>> Martin Bonner skrev:
>>
>>>>> namespace boost
>>>>> {
>>>>>     namespace ptr_container_detail
>>>>>     {
>>>>>         const char* count  = "count";
>>>>>         const char* item   = "item";
>>>>>         const char* first  = "first";
>>>>>         const char* second = "second";
>>>>>     }
>>>>> }
>>>> Thanks. Is there an easy way to fix it?
>>>>
>>>> -Thorsten
>>> One option would be:
>>>     namespace ptr_container_detail
>>>     {
>>>        const char* count() { return "count"; }
>> with an "inline" in front of each function, I presume?
> 
> Oops!  I missed that they are namespace level rather than class members.
> 
> 
> Yes, an "inline" would improve things markedly.
> 
> 

Err don't you just need to make them const so that they have internal 
linkage?

i.e.

namespace boost
{
     namespace ptr_container_detail
     {
         const char* const count  = "count";
         const char* const item   = "item";
         const char* const first  = "first";
         const char* const second = "second";
     }
}

Thanks,

Michael Marcin