Re: [boost] [python] gcc-warnings

From: David Abrahams (dave_at_[hidden])
Date: 2007-12-02 22:52:28

on Sun Dec 02 2007, "Peter Dimov" <pdimov-AT-pdimov.com> wrote:

> David Abrahams:
>
>> Uh, no thanks.  I *want* the test to compile away in release mode.
>> See http://lists.boost.org/Archives/boost/2006/06/106919.php .  I
>> think one of these already exists somewhere in Boost.Python.
>
> The expression is a simple bool variable, its disappearance in release mode 
> doesn't buy you much. Presumably, had you wanted the test to compile away, 
> you'd have used
>
>     BOOST_ASSERT( get_source.convertible() );
>
>
>>> Index: boost/python/converter/implicit.hpp
>>> ===================================================================
>>> --- boost/python/converter/implicit.hpp (revision 41535)
>>> +++ boost/python/converter/implicit.hpp (working copy)
>>> @@ -32,7 +32,7 @@
>>>
>>>          arg_from_python<Source> get_source(obj);
>>>          bool convertible = get_source.convertible();
>>> -        BOOST_ASSERT(convertible);
>>> +        BOOST_VERIFY(convertible);

Good point.  Okay, that change is fine.

-- 
Dave Abrahams
Boost Consulting
http://www.boost-consulting.com