Re: [boost] [review] Review of Unordered library begins today December 7

From: John Torjo (john.groups_at_[hidden])
Date: 2007-12-12 08:14:17

> Here are some questions you might want to answer in your review:
>
> * What is your evaluation of the design?
>   
Looks good to me.
> * What is your evaluation of the implementation?
>   
Looks good, haven't looked much into the detail/ folder
> * What is your evaluation of the documentation?
>   
Good.
> * What is your evaluation of the potential usefulness of the library?
>   
Extremely useful.
> * Did you try to use the library? With what compiler?
>    Did you have any problems?
>   
Haven't tried
> * How much effort did you put into your evaluation?
>    A glance? A quick reading? In-depth study?
>   
Quick reading.
> * Are you knowledgeable about the problem domain?
>
>   
I've used hash_map implementations in the past.
> And finally, every review should answer this question:
>
> * Do you think the library should be accepted as a Boost library?
>    Be sure to say this explicitly so that your other comments
>    don't obscure your overall opinion.
>
>   
Yes, definitely!

Best,
John

-- 
http://John.Torjo.com -- C++ expert
... call me only if you want things done right