Re: [boost] [iterator, test] Patches for PA_RISC HP-UX 11.11 compatibility

From: Gennadiy Rozental (rogeeff_at_[hidden])
Date: 2007-12-13 22:06:18

"Jurko Gospodnetic" <jurko.gospodnetic_at_[hidden]> wrote in message 
news:fjsesi$un8$1_at_ger.gmane.org...
>   Hi.
>
>   Thank you for the reply.
>
>> Sorry, for the delay. I did see your patch and I am not sure I understand 
>> it.
>>
>> How removing somespaces and some variable name change helps this 
>> compiler?
>>
>>> -    predicate_result    res( true );
>>> +    predicate_result res( true );
>
>   That change is not strictly needed but only seemed the right cosmetic
> 'thing to do' a few lines above. And since it was 'only whitespace' we
> did not remove it.
>
>
>>> -    static Left const  L1( 1 );
>>> -    static Right const R1( 1 );
>>> +    static Left  const leftOne ( 1 );
>>> +    static Right const rightOne( 1 );
>
>   HP-UX pa-risc 11.11 system headers define a macro R1 to mean 1 so
> local variables named R1 in boost code cause a compilation error. L1 was
> changed to keep it in sync with its R1 counterpart.
>
>   Thanks again.

Can't we just under these, obviosly dangerous macros?

You can go ahead. No need to hide it under ifdef either. Add proper comment 
in log.

Gennadiy