Re: [boost] [1.35.0] Release branch frozen

From: Beman Dawes (bdawes_at_[hidden])
Date: 2008-03-16 17:48:10

Ion Gaztañaga wrote:
> Beman Dawes wrote:
>> The release branch is frozen. Please make no further changes without 
>> explicit permission from me.
> 
> I've received a trivial to fix bug report (#1683):
> 
> #1683: Boost Intrusive - Superflous template parameter
> --------------------------------+-------------------------------------------
>   Reporter:  boost_at_[hidden]  |       Owner:  igaztanaga
>       Type:  Bugs                |      Status:  new
> Milestone:  Boost 1.35.0        |   Component:  intrusive
>    Version:  Boost 1.34.1        |    Severity:  Problem
>   Keywords:                      |
> --------------------------------+-------------------------------------------
>   In boost/intrusive/unordered_set.hpp
> 
>      template<class KeyType, class KeyHasher, class KeyValueEqual, class
>   Disposer>
>      size_type count(const KeyType& key, KeyHasher hash_func, KeyValueEqual
>   equal_func) const
>      {  return table_.count(key, hash_func, equal_func);  }
> 
> 
>   The 'class Disposer' template argument is superflous. With that there, 
> the  compiler is not able to automatically infer the template types so I 
> can't write foo.count<>(key,hash,equal).
> 
> /////////////////////
> 
> The fix is trivial and does not affect regression testing (because if 
> this function would be instantiated by any test case, it wouldn't 
> compile). Could I fix this both in release and trunk?

Fix it in trunk, then hold a day or so to let tests cycle, then fix in 
release if it's OK in trunk testing.

Even though the fix is trivial, there is always the chance of some 
unexpected snafu. We want to get RC2 ready by the middle of the week, 
and want minimal chance of delay.

Thanks,

--Beman