Re: [boost] [1.35.0] Release branch frozen - bug in circular buffer

From: Jan Gaspar (jano_gaspar_at_[hidden])
Date: 2008-03-17 17:52:52

Hi,

there is a serious bug in the circular_buffer library (http://svn.boost.org/trac/boost/ticket/1692) which makes it unusable in the release mode (there are several more methods affected not only erase() as described in the ticket). Can I commit the fix into the release branch?

Original code:
{{{
  /boost/boost/circular_buffer/details.hpp  (r1.4)
                  class  iterator
  222  #if  !defined(BOOST_CB_TEST)  && BOOST_CB_ENABLE_DEBUG == 0
  223  private:
  224  #endif
  225  //  Member  variables
  226
  227        //!  The  circular  buffer  where  the  iterator  points  to.
  228        const  Buff*  m_buff;
  229
  230        //!  An  internal  iterator.
  231        pointer  m_it;
  }}}

New code:
{{{
   /boost/boost/circular_buffer/details.hpp  (r1.4)
                   class  iterator
   222 public:
223  //  Member  variables
   224
   225        //!  The  circular  buffer  where  the  iterator  points  to.
   226        const  Buff*  m_buff;
   227
   238        //!  An  internal  iterator.
   239        pointer  m_it;
   }}}


Jan


----- Original Message ----
From: Beman Dawes <bdawes_at_[hidden]>
To: Boost mailing list <boost_at_[hidden]>
Sent: Friday, 14 March, 2008 1:33:05 PM
Subject: [boost] [1.35.0] Release branch frozen

The  release  branch  is  frozen.  Please  make  no  further  changes  without 
explicit  permission  from  me.

RC1  is  being  generated.

--Beman
_______________________________________________
Unsubscribe  &  other  changes:  http://lists.boost.org/mailman/listinfo.cgi/boost




Send instant messages to your online friends http://uk.messenger.yahoo.com