Re: [boost] Preview 2 of a template Geometry Library

From: Barend Gehrels (barend_at_[hidden])
Date: 2008-03-27 15:37:44

> AMDG
>
> I noticed the equals function in math.hpp.
> I'm not sure about it.  If a and b are both greater than 1 than if their 
> difference
> is non-zero, it cannot be less than epsilon (which is defined as "the 
> difference
> between 1 and the least value greater than 1 that is representable" 
> 18.2.1.2)
> Thus, the test is equivalent to a == b.
>
> Also, the include guard is _GEOMETRY_MATH_HPP
> "Each name that [...] begins with an underscore followed by an uppercase
> letter (2.11) is reserved to the implementation for any use."  (17.4.3.1.2)
>
> In Christ,
> Steven Watanabe
>   

Steven,

The math.hpp contains things that should not be in this library, I would 
like to have them replaced by something in Boost, or maybe they are 
already in Boost but I overlooked them. I put them there to make it easy 
to change lateron, and it needs probably change indeed. Thanks.

The include guards were thought to be preceded by something else... No 
problem to change them.

Barend Gehrels
Geodan, Amsterdam