[boost] [date_time] Re: Bug in 1.35: header inclusion order dependency introduced between recursive_mutex.hpp and asio.hpp on Windows

From: Anthony Williams (anthony_w.geo_at_[hidden])
Date: 2008-03-31 11:17:54

"James Talbut" <James.Talbut_at_[hidden]> writes:

> recursive_mutex.hpp include windows.h, which includes winsock.h.
> asio.hpp barfs if winsock.h has been included.
>  
> Clearly it's not boost's fault that windows.h and winsock2.h have
> inclusion order problems, but this change will break code that currently
> uses them both.

The boost thread code only includes windows.h if BOOST_USE_WINDOWS_H is
defined. This is what is used in shared_ptr and interprocess to protect
<windows.h>, so shouldn't cause a problem.

Doing a grep for windows.h shows that it *is* included by the Boost date-time
library, which boost.thread now depends on. I've CCed this to Jeff, to see if
he can suggest a fix.

Anthony
-- 
Anthony Williams            | Just Software Solutions Ltd
Custom Software Development | http://www.justsoftwaresolutions.co.uk
Registered in England, Company Number 5478976.
Registered Office: 15 Carrallack Mews, St Just, Cornwall, TR19 7UL