Re: [boost] Preliminary Review Request: boost-memory

From: shiwei xu (xushiweizh_at_[hidden])
Date: 2008-05-08 11:39:34

Thanks tim. I took a look at the boost lockfree library. And I have some
suggestions:

1. freelist

template <typename T, std::size_t max_size = 64>
class freelist : public dummy_freelist<T>
{ ... };

I think the following is better:

template <typename T, typename Alloc = dummy_freelist<T>, std::size_t
max_size = 64>
class freelist
{
    Alloc m_alloc;
};

2. explicit keyword

stack(unsigned int n);  => explicit stack(unsigned int n);
freelist(std::size_t initial_nodes); => explicit freelist(std::size_t
initial_nodes);

Best Regards,

Shiwei Xu

On Thu, May 8, 2008 at 7:14 PM, Tim Blechmann <tim_at_[hidden]> wrote:

> here you go:
> http://tim.klingt.org/git?p=boost_lockfree.git;a=summary
>
> lockfree stack with aba prevention and freelist ...
>