Re: [boost] Inspection report and non-ASCII characters

From: Marshall Clow (marshall_at_[hidden])
Date: 2008-06-30 18:02:11

At 5:59 PM -0400 6/30/08, Beman Dawes wrote:
>John Maddock wrote:
>>
>>Would it be possible for the inspection report to print out the 
>>line containing the non-ASCII characters?  There are a few files 
>>that are being flagged up, where I just can't find anything wrong 
>>with them :-(
>
>Hum... Take a look at trunk\tools\inspect\ascii_check.cpp
>
>It seems misnamed; it is apparently really checking for characters 
>the c++ standard says are OK in source programs, regardless of 
>encoding.
>
>Also, I notice the code:
>
>          if ( c >= 'a' && c <= 'z' ) return false;
>          if ( c >= 'A' && c <= 'Z' ) return false;
>
>That isn't right for EBCDIC. See 
>http://en.wikipedia.org/wiki/EBCDIC. Although that is being pedantic 
>- there is little chance the code will ever run on an non-ASCII 
>system.
>
>But before changing anything, we really need to figure out what our 
>Boost standard is. How about anything 0x20-0x7E plus 0x09, 0x0A, 
>0x0D?

I'll be happy to make that change, and to print the offending line - 
just let me know what people want ;-)
-- 
-- Marshall
Marshall Clow     Idio Software   <mailto:marshall_at_[hidden]>
It is by caffeine alone I set my mind in motion.
It is by the beans of Java that thoughts acquire speed,
the hands acquire shaking, the shaking becomes a warning.
It is by caffeine alone I set my mind in motion.