Re: [boost] libs/dynamic_bitset/bitset_test unmerged changes?

From: Gennaro Prota (gennaro.prota_at_[hidden])
Date: 2008-07-05 07:06:59

David Abrahams wrote:
> Should these be in the trunk?
> 
> Index: bitset_test.hpp
> ===================================================================
> --- bitset_test.hpp	(revision 40672)
> +++ bitset_test.hpp	(working copy)
> @@ -1006,7 +1006,8 @@
>  
>      bool did_throw = false;
>      try {
> -      s << b;
> +      static_cast<void>
> +          (s << b);
>      }
>  #if defined BOOST_OLD_IOSTREAMS
>      catch(...) {
> @@ -1081,7 +1082,8 @@
>      const std::ios::iostate except = is.exceptions();
>      bool has_stream_exceptions = true;
>      try {
> -      is >> b;
> +      static_cast<void>
> +          (is >> b);
>      }
>      catch(const std::ios::failure &) {
>        did_throw = true;
> 

This was a RC_1_34_0 change, made to silent a Digital Mars (!) 
warning. It is only relevant if Digital Mars is being regression 
tested /and/ any of the tested version(s) still emit that (stupid) 
warning. Otherwise I'd definitely leave the code as is, and not merge 
the change.

-- 
Genny