Re: [boost] [exception] missing workarounds for msvc 4265 warning

From: Juergen Hunold (juergen.hunold_at_[hidden])
Date: 2008-08-19 14:50:41

Hi Michael !

On Tuesday 19 August 2008 18:36:39 Michael Marcin wrote:

> Since MSVC provides a way to disable warnings in code wouldn't it be
> better to pragma push, warning disable, and pop then to actually change
> the code?

That would change four source files due to the fact that the "missing" 
destructor is inherited :-((. And the destructors have to be implemented for 
gcc anyway. And taking a second look it would probably be the best solution to 
just implement (empty) virtual destructors for all platforms.
And just because #ifdef considered harmful :))
But I'd rather have the maintainer do the right thing :-))

Yours,

Jürgen

-- 
* Dipl.-Math. Jürgen Hunold       ! Ingenieurgesellschaft für 
* voice: ++49 511 262926 57       ! Verkehrs- und Eisenbahnwesen mbH  
* fax  : ++49 511 262926 99       ! Lister Straße 15
* juergen.hunold_at_[hidden]        ! www.ivembh.de
* 
* Geschäftsführer:                ! Sitz des Unternehmens: Hannover
* Prof. Dr.-Ing. Thomas Siefer    ! Amtsgericht Hannover, HRB 56965
* PD Dr.-Ing. Alfons Radtke       !