Re: [boost] [review] Dataflow Review starts today, September 1st

From: Stjepan Rajko (stipe_at_[hidden])
Date: 2008-09-01 13:44:18

On Mon, Sep 1, 2008 at 9:35 AM, Giovanni Piero Deretta
<gpderetta_at_[hidden]> wrote:
> On Mon, Sep 1, 2008 at 7:19 AM, Jaakko Järvi <jarvi_at_[hidden]> wrote:
>> The review of Stjepan Rajko's Dataflow library starts today, September 1st,
>> and will run until September 10th.
>>
>
> Hi, while skimming through the Dataflow documentation, I noticed an
> error in the distributed example (http://tinyurl.com/5qcjxx):
>

Thanks for raising this issue - threading is definitely not my forte,
and it's quite possible that I'm doing something weird.  I see,
looking at the docs:

template <typename ScopedLock>
    void wait(ScopedLock& lock);

Danger: This version should always be used within a loop checking that
the state logically associated with the condition has become true.
Without the loop, race conditions can ensue due to possible "spurious
wake ups".

I wasn't aware of the "spurious wake ups" issue.  I will fix the code
as you recommended.

>
> BTW, hopefully I'll be able to write a review. The library seems interesting.
>

That would be great!

Thanks,

Stjepan