Re: [boost] [threadpool]thread management strategies

Subject: Re: [boost] [threadpool]thread management strategies
From: vicente.botet (vicente.botet_at_[hidden])
Date: 2008-09-17 14:04:20

Hi Olivier,

----- Original Message ----- 
From: <k-oli_at_[hidden]>
To: <boost_at_[hidden]>
Sent: Tuesday, September 16, 2008 2:45 PM
Subject: Re: [boost] [threadpool]thread management strategies

>
> Hello Vicente,
> thank you for looking through the code.
>
 Am Dienstag, 16. September 2008 07:37:47 schrieb vicente.botet:
>> * In adaptive and lazy add the assertion on constructor
>> BOOST_ASSERT( lwm <= hwm);
>
> I've romved the assertion because it is a runtime error (user defines 
> vaules)
> and bounded_channel already checks high- and low watermark.

Does it means that you can remove it on fixed.hpp (230)?

>> * In lazy
>>   std::size_t max_size()
>>   {
>>             return max_size_;
>>   }
>> should't have a shared_lock guard.
>
>
> Because max_size_ is a invariante I beleive it is safe to leave it 
> unprotected
> (mutex).

In the case of adaptive the guard is used, so ...

As you don't comment the other points, do you mean that you will takes these 
points in account?

>> thread_management<fixed> to mean the current fixed
>> thread_management<variable<AdjustmentPolicy> >  to mean the current
>> lazy<AdjustmentPolicy>
>> thread_management<variable<AdjustmentPolicy, shrink<RecreatePolicy> > >
>> What do you think?
>
> Looks interesting - I've to think up how to realize it in C++.

Let me know if I can help.

Best,

Vicente