Re: [boost] Win64 and abi_prefix.hpp/abi_suffix.hpp warnings

Subject: Re: [boost] Win64 and abi_prefix.hpp/abi_suffix.hpp warnings
From: Juergen Hunold (juergen.hunold_at_[hidden])
Date: 2008-09-29 03:50:52

Hi John !

On Friday 26 September 2008 10:40:32 John Maddock wrote:
> Chris Newbold wrote:
> >>> I'm unclear on the rationale for forcing 8-byte alignment in
> >>> config/abi/msvc_(pre|suf)fix.hpp: 8-byte alignment is the compiler
> >>> default. Is there concern over Boost headers being included in a
> >>> context where the alignment has been otherwise artificially altered?
>
> Yes: it's to ensure that the included header is binary compatible with the
> boost binaries, which are all built with default alignment settings.

Could you please add the sentence as comment to prefix.hpp ? This would make 
things much clearer for the reader ;-))

> Unless there are any violent objections, I'm going to commit the x64 fix
> soon, but what do folks feel about suppressing the warnings globally as
> well?

It seems the x64 fix is the right way. Simply disabling the warning is a bad 
thing. But disabling and reenabling the warning in every place is a tedious 
job. Please find my try at this attached.
I think if someone is messing with the aligment she will want to know about 
the forced alignment in Boost libraries.
I'm +1 for the x64 fix and +1 for "don't suppress the warning".

Yours,

Jürgen
-- 
* Dipl.-Math. Jürgen Hunold       ! Ingenieurgesellschaft für 
* voice: ++49 511 262926 57       ! Verkehrs- und Eisenbahnwesen mbH  
* fax  : ++49 511 262926 99       ! Lister Straße 15
* juergen.hunold_at_[hidden]        ! www.ivembh.de
* 
* Geschäftsführer:                ! Sitz des Unternehmens: Hannover
* Prof. Dr.-Ing. Thomas Siefer    ! Amtsgericht Hannover, HRB 56965
* PD Dr.-Ing. Alfons Radtke       !