|
Boost : |
Subject: Re: [boost] [UUID] version v12
From: Atry (pop.atry_at_[hidden])
Date: 2008-10-09 01:15:23
Hi Andy,
I saw the source code in seed_rng.hpp, I found you use an
uninitialized buffer[] if fopen fails. It often rely on the stack
contents when previous calling function runs, and that is not always
random.
I think UUID does not need to be random, it just need to be uniquely.
So the seed should contains process id, time, MAC address and so on.
2008/10/9 Andy Tompkins <atompkins_at_[hidden]>:
> Hi Johannes,
>
> On Wed, 8 Oct 2008 15:03:54 +0200, "Johannes Brunen"
> <JBrunen_at_[hidden]> said:
>> Hello Andy,
>>
>> I just did a small test with the latest uuid library from the vault.
>>
>> IMHO, I found a small error in file uuid.hpp (line 303): function
>> hash_value
>> must be inlined as it is not a template function.
>
> Absolutely correct. Thanks. I will fix this.
>
>>
>> Additional is seems that the documentation is out of sync with the
>> implementation. The section 'design notes' is still refering to a former
>> implementation with the create(...) functions.
>
> Again, absolutely correct. Thanks. I will fix this too.
>
>>
>> Otherwise, I could compile and link the code on msvc .net 2008 with my
>> setup.
>>
>> thanks for your library,
>>
>> best
>>
>> Johannes
>>
>
> Thank you,
> Andy Tompkins
> _______________________________________________
> Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
>
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk