Re: [boost] [review][constrained_value] Review of Constrained ValueLibrary begins today

Subject: Re: [boost] [review][constrained_value] Review of Constrained ValueLibrary begins today
From: vicente.botet (vicente.botet_at_[hidden])
Date: 2008-12-03 16:36:51

----- Original Message ----- 
From: "Jeff Garland" <azswdude_at_[hidden]>
To: <boost_at_[hidden]>
Sent: Wednesday, December 03, 2008 9:47 PM
Subject: Re: [boost] [review][constrained_value] Review of Constrained ValueLibrary begins today

> 
> On Wed, Dec 3, 2008 at 10:32 AM, John Maddock <john_at_[hidden]>wrote:
> 
>>
>> Also I'm a little surprised that there are no tests as yet: rather lets
>> down an otherwise nice submission.
>>
>> **** I believe the review manager should not allow full acceptance until a
>> decent set of tests are provided ****
>>
> 
> Completely agree -- any acceptance will be conditioned on the addition of
> tests.  I actually asked Robert about this prior to the review because I
> could see the lack of tests becoming an issue for reviewers. I decided to go
> forward with the review since I agreed with his point that the examples
> basically exercise most of the libraries features.  Also,
> 
> http://www.boost.org/community/reviews.html#Review_Manager
> 
> didn't provide clear guidance on this point. It's possible there should be a
> clearer policy on this point for the future.

Hi,
FYI,

http://www.boost.org/community/reviews.html#Review_Manager contains
"The Review Manager:

Checks the submission to make sure it really is complete enough to warrant formal review. See the Boost Library Requirements and Guidelines. If necessary, work with the submitter to verify the code compiles and runs correctly on several compilers and platforms."

Boost Library Requirements and Guidelines contains
"Provide sample programs or confidence tests so potential users can see how to use your library.
Provide a regression test program or programs which follow the Test Policies and Protocols."

Test Policies and Protocols contains
"Test Policy
Required
Every Boost library should supply one or more suitable test programs to be exercised by the Boost regression test suite. In addition to the usual compile-link-run tests expecting successful completion, compile-only or compile-and-link-only tests may be performed, and success for the test may be defined as failure of the steps.
Test program execution must report errors by returning a non-zero value. They may also write to stdout or stderr, but that output should be relatively brief. Regardless of other output, a non-zero return value is the only way the regression test framework will recognize an error has occurred. Note that test programs to be included in the status tables must compile, link, and run quickly since the tests are executed many, many, times.
Libraries with time consuming tests should be divided into a fast-execution basic test program for the status tables, and a separate full-coverage test program for exhaustive test cases. The basic test should concentrate on compilation issues so that the status tables accurately reflect the library's likelihood of correct compilation on a platform.
If for any reason the usual test policies do not apply to a particular library, an alternate test strategy must be implemented.
A Jamfile to drive the regression tests for the library."

Best,

Vicente