Re: [boost] [log] Review-ready version in the Vault

Subject: Re: [boost] [log] Review-ready version in the Vault
From: Andrey Semashev (andrey.semashev_at_[hidden])
Date: 2009-02-10 12:40:37

Peter Simons wrote:
> Hi Andrey,
> 
>  > For some reason bjam doesn't append -I$(BOOST_ROOT)/libs/log/test/common
>  > to GCC command line.
> 
> now I got it. The parameter was added to the command line, alright, but it
> didn't do anything because the assumption that Boost.Log has been copied
> into the rest of the Boost source code is wrong, i.e. my "test/common"
> directory is not underneath $BOOST_ROOT. The following patch fixes the
> problem.
> 
> --- a/libs/log/test/Jamfile.v2
> +++ b/libs/log/test/Jamfile.v2
> @@ -8,7 +8,7 @@ import testing ;
> 
>  project
>      : requirements
> -        <include>$(BOOST_ROOT)/libs/log/test/common
> +        <include>common
>          <toolset>msvc:<define>_SCL_SECURE_NO_DEPRECATE
>          <toolset>msvc:<define>_CRT_SECURE_NO_DEPRECATE
>          <library>/boost/log//boost_log

Great! I wasn't sure from which directory bjam would start looking for 
relative paths, so I wrote the complete one.

> With that change applied, all tests but one succeed -- "attr_attribute_set"
> still doesn't seem to compile. The build log is attached to this e-mail. To
> you have any idea what the problem might be?

The problem is the GCC's STL implementation specifics. Looks like it 
uses assignment to put an element into a vector, which prevents from 
using const types as the element members (std::pair in this case). I'm 
using STLPort, that's why this one went unnoticed.

Fixed both the test and the Jamfile in CVS. Thanks for your feedback!