Re: [boost] [tuple] gcc warnings

Subject: Re: [boost] [tuple] gcc warnings
From: David Abrahams (dave_at_[hidden])
Date: 2009-02-26 13:35:07

On Feb 24, 2009, at 5:11 PM, Steven Watanabe wrote:

> AMDG
>
> I've tested the fix for #2388 and it looks ok.
> Okay to commit?
>
> In Christ,
> Steven Watanabe
>
> Index: boost/tuple/tuple_comparison.hpp
> ===================================================================
> --- boost/tuple/tuple_comparison.hpp	(revision 51422)
> +++ boost/tuple/tuple_comparison.hpp	(working copy)
> @@ -69,8 +69,8 @@
> template<class T1, class T2>
> inline bool lt(const T1& lhs, const T2& rhs) {
>   return lhs.get_head() < rhs.get_head()  ||
> -            !(rhs.get_head() < lhs.get_head()) &&
> -            lt(lhs.get_tail(), rhs.get_tail());
> +          ( !(rhs.get_head() < lhs.get_head()) &&
> +            lt(lhs.get_tail(), rhs.get_tail()));
> }
> template<>
> inline bool lt<null_type,null_type>(const null_type&, const  
> null_type&) { return false; }
> @@ -78,8 +78,8 @@
> template<class T1, class T2>
> inline bool gt(const T1& lhs, const T2& rhs) {
>   return lhs.get_head() > rhs.get_head()  ||
> -            !(rhs.get_head() > lhs.get_head()) &&
> -            gt(lhs.get_tail(), rhs.get_tail());
> +          ( !(rhs.get_head() > lhs.get_head()) &&
> +            gt(lhs.get_tail(), rhs.get_tail()));
> }

Hi Steven,

Go ahead; you don't even need to ask about a fix like that one.

--
David Abrahams
BoostPro Computing
http://boostpro.com