Re: [boost] [Review] Polynomial library review begins today

Subject: Re: [boost] [Review] Polynomial library review begins today
From: Chris Card (ctcard_at_[hidden])
Date: 2009-03-17 04:28:41

On Tue, 10 Mar 2009 12:23:07 -0000, John Maddock <john_at_[hidden]>
wrote:

 

> The review of Pawel Kieliszczyk's Polynomial library begins today and  

> ends on Thurs 19th March.

I just saw this and I have a few comments on the interface to the Polynomial
class.

 

1. the name FieldType is mathematically misleading since the instantiating
type is very likely not to be a field (e.g. int or a multiple precision
integer type).

 

2. the Polynomial class provides a fairly minimilist set of supported
functions. This may well be deliberate (if so, apologies), but I would like
to see a richer interface including such things as

            - content (gcd of coefficients, where that makes sense)

            - polynomial discriminant

            - resultant of 2 polynomials

            - evaluation of homogeneous polynomial ( f(x) = sum c_i x^i,
f(a,b) = sum c_i a^i b^(d-i) )

            - evaluation at a polynomial (f(g(x)))

            - Pseudo-division of polynomials

            - finding roots over C

            - finding roots over F_p

            - factorisation over Z

            - factorisation over F_p

 

Chris