Re: [boost] [Review Request] polygon

Subject: Re: [boost] [Review Request] polygon
From: Steven Watanabe (watanabesj_at_[hidden])
Date: 2009-06-23 16:29:44

AMDG

Simonson, Lucanus J wrote:
> Gtl was renamed to boost::polygon.
>
> The source is available at
> https://svn.boost.org/svn/boost/sandbox/gtl/boost/polygon/
> And the documentation is at
> https://svn.boost.org/svn/boost/sandbox/gtl/doc/index.htm
>
> I have a review manager and a number of prospective reviewers lined up, so we should be able to at least get the review started smoothly.
>
> I would like the review wizard to contact me off list to discuss which dates are more suitable to have the review given my personal schedule.
>   

I suggest that you run the inspect tool.

Here'e the summary for the source:
1 files missing Boost license info or having wrong reference text
1 files missing copyright notice
6 files with tabs
74 violations of the Boost min/max guidelines

polygon.hpp line 12:
You should generally use cmath instead of math.h in C++

Many of the headers cannot stand alone, because
they do not #include the other headers that they depend on.
If you don't want them to be included directly they should
go in a subdirectory called detail or something similar.

In Christ,
Steven Watanabe