Re: [boost] [warnings] Are warnings acceptable artifactsfrom builds?

Subject: Re: [boost] [warnings] Are warnings acceptable artifactsfrom builds?
From: Stewart, Robert (Robert.Stewart_at_[hidden])
Date: 2009-09-09 08:31:04

Thomas Klimpel wrote:
> Michael Fawcett wrote:
> > Frankly, after just having reviewed (by using) a library
> > that spit out
> > 60+ warnings resulting in hundreds of kilobytes worth of warning
> > messages, I have to disagree.  Those warnings become my
> > business when
> > I have to wade through them just to find the bloody error message.
>
> I have also reviewed that library. There were far too many
> warnings, but some of the warnings really were nonsense (in
> the sense that fixing the compiler would be more reasonable
> than trying to work around the warnings).

Which is the more likely?  Even if you could see the compiler fixed, it will only help those users that use the newer version.

> Thomas Klimpel wrote:
> > - It is true that msvc-9 spits out many warnings. However,
> > it is also
> > true that "warning C4127: conditional expression is
> > constant" for a code like
> >  template <typename value_type, typename geometry_type_1,
> > typename geometry_type_2, int op_type>
> >  void execute_boolean_op(value_type& output_, const
> > geometry_type_1& lvalue_, const geometry_type_2& rvalue_,
> >      ...
> >      if(op_type < 2)
> > is nonsense, because op_type is a template parameter. So I have the
> > impression that the only way to get rid of the msvc warnings is by
> > disabling the nonsense warnings with appropriate pragmas.
>
> I don't know what about the boost way to silence warnings,
> but if it is along the line of
>
> #ifdef BOOST_WARNING_MSVC_WORKAROUND
> #pragma warning(push)
> #pragma warning(disable:4127)
> #endif
>
> ...
>
> #ifdef BOOST_WARNING_MSVC_WORKAROUND
> #pragma warning(pop)
> #endif

Those could easily be macros, thus reducing the source code burden.

_____
Rob Stewart                           robert.stewart_at_[hidden]
Software Engineer, Core Software      using std::disclaimer;
Susquehanna International Group, LLP  http://www.sig.com

IMPORTANT: The information contained in this email and/or its attachments is confidential. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this message or any attachment by an unintended recipient is strictly prohibited. Neither this message nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this message or any of its attachments is free of viruses.