Re: [boost] Re : BOOST_FOREACH like macro for map

Subject: Re: [boost] Re : BOOST_FOREACH like macro for map
From: Stewart, Robert (Robert.Stewart_at_[hidden])
Date: 2009-10-21 08:44:37

Steven Watanabe wrote:
> Stewart, Robert wrote:
> >
> >    template <class T, class U>
> >    U const &
> >    get_value(std::map<T,U> const & _map, T const & _key)
> >    {
> >       typename std::map<T,U>::const_iterator it(_map.find(_key));
> >       if (it != _map.end())
> >       {
> >          return it->second;
> >       }
> >       throw std::domain_error("key not found");
> >    }
>
> Wouldn't it be better to return a null pointer instead of throwing an
> exception?

The original use case was written assuming the element was found.  To satisfy that, you need to return a reference and throw an exception.  If the OP is happy with testing a pointer, I agree with you.

_____
Rob Stewart                           robert.stewart_at_[hidden]
Software Engineer, Core Software      using std::disclaimer;
Susquehanna International Group, LLP  http://www.sig.com

IMPORTANT: The information contained in this email and/or its attachments is confidential. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this message or any attachment by an unintended recipient is strictly prohibited. Neither this message nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this message or any of its attachments is free of viruses.