Subject: Re: [boost] Boost policy for putting headers in boost/ Was: #3541Support <boost/ptr_map.hpp>
From: Stewart, Robert (Robert.Stewart_at_[hidden])
Date: 2009-11-02 14:18:35
Joel de Guzman wrote:
> David Abrahams wrote:
> > Have you actually got a name clash situation like that one, BTW?
> Yes. Spirit2 includes both "classic" and "qi" in there as well
> as "karma". There are lots of similar names such as rule.hpp,
> grammar.hpp that are found in each of the modules. In our flat
> include, we have to prepend them with "classic", "qi" and "karma"
> to disambiguate. Compare these (flat vs. modular) files for instance:
> #include <boost/spirit/qi/nonterminal/grammar.hpp>
> #include <boost/spirit/include/qi_grammar.hpp>
> And this:
> #include <boost/spirit/karma/nonterminal/grammar.hpp>
> #include <boost/spirit/include/karma_grammar.hpp>
That makes the "include" subdirectory that much worse. There should only be one way to find the required header contents.
I don't have a problem with the general idea of modularizing a library. It does follow the top level directory pattern nicely. I still would rather have less clutter in a given directory by pushing something akin to "all.hpp" into the subdirectory rather than near-duplicating the directory name, but the alternative is consistent and usable.
Rob Stewart robert.stewart_at_[hidden]
Software Engineer, Core Software using std::disclaimer;
Susquehanna International Group, LLP http://www.sig.com
IMPORTANT: The information contained in this email and/or its attachments is confidential. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this message or any attachment by an unintended recipient is strictly prohibited. Neither this message nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this message or any of its attachments is free of viruses.
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk