Re: [boost] [1.41.0] Release branch closed for all changes; beta RC tomorrow

Subject: Re: [boost] [1.41.0] Release branch closed for all changes; beta RC tomorrow
From: Tim Blechmann (tim_at_[hidden])
Date: 2009-11-05 06:17:23

On 11/02/2009 01:43 AM, Emil Dotchevski wrote:
> On Sun, Nov 1, 2009 at 4:23 AM, Tim Blechmann <tim_at_[hidden]> wrote:
>>> The release branch is closed for all changes. Unless someone objects
>>> strenuously, I'll build a release candidate for the beta tomorrow
>>> (Tuesday) morning, eastern US time.
>>
>> using the current release branch, i get the following warnings
>> (gcc-4.4.1, x86_64-linux-gnu)
>>
>> libs/boost/boost/exception/detail/exception_ptr_base.hpp:17: warning:
>> 'class boost::exception_detail::exception_ptr_base' has virtual
>> functions and accessible non-virtual destructor
>> [snip]
>> libs/boost/boost/exception_ptr.hpp:43: warning: 'class
>> boost::exception_ptr' has virtual functions and accessible non-virtual
>> destructor
>>
>> hth, tim
> 
> Tim, thanks for spotting this.
> 
> I'm attaching a patch that fixes this very minor issue. It should be
> safe to include in the release, but could wait. I've only tested the
> patch with MSVC and GCC. If it remains uncommitted, I'll commit it
> after 1.41 is out.

btw, i need to use the following patch to get rid of the second warning:

diff --git a/boost/exception_ptr.hpp b/boost/exception_ptr.hpp
index 91dce25..592e8b9 100644
--- a/boost/exception_ptr.hpp
+++ b/boost/exception_ptr.hpp
@@ -90,6 +90,8 @@ boost
             {
             }

+        virtual ~exception_ptr() throw() {}
+
         operator unspecified_bool_type() const
             {
             return _empty() ? 0 : &exception_ptr::bad_alloc_;

-- 
tim_at_[hidden]
http://tim.klingt.org
A year ago, six months ago, I thought that I was an artist. I no
longer think about it, I am.
  Henry Miller