Subject: Re: [boost] Official warnings policy?
From: Stewart, Robert (Robert.Stewart_at_[hidden])
Date: 2009-11-11 14:35:47
Paul A. Bristow wrote:
> Richard Webb wrote:
> > Looks like the warnings occur depending on the types used
> > in the unit tests.
> > For example, the warning mentioned above comes from the test code:
> > typedef variant< short, const char* > t_var2;
> > typedef variant< unsigned short, const char*, t_var2 > t_var5;
> > typedef variant< unsigned short, const char*, t_var5 > t_var6;
> > t_var6 v6;
> > v6 = 58;
> > Which looks like a legitimate warning about converting an
> > integer (58) to a short.
> Since this is expected, could the test use a static_cast to
> the right type?
The whole problem here is that the t_var6 type is driven by the template parameter list, so the range of that type may be insufficient, depending upon the template arguments. If the template doesn't validate the range of t_var6, then the assignment may overflow, just as the warning indicates.
I created a checked_cast that does a static_cast after validating against the upper and lower bounds, when necessary, for this very purpose. (Using TMP, it determines the signedness of the types involved, their relative sizes, etc., to compare as little as possible to validate the conversion.)
Rob Stewart robert.stewart_at_[hidden]
Software Engineer, Core Software using std::disclaimer;
Susquehanna International Group, LLP http://www.sig.com
IMPORTANT: The information contained in this email and/or its attachments is confidential. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this message or any attachment by an unintended recipient is strictly prohibited. Neither this message nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this message or any of its attachments is free of viruses.
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk