Subject: Re: [boost] Official warnings policy?
From: Stewart, Robert (Robert.Stewart_at_[hidden])
Date: 2009-11-12 12:58:12
Emil Dotchevski wrote:
> On Thu, Nov 12, 2009 at 8:48 AM, Stewart, Robert
> <Robert.Stewart_at_[hidden]> wrote:
> > Peter Dimov wrote:
> >> The test tests whether an int can be assigned to a variant,
> >> one of whose types is a short. It should produce a warning;
> >> in this context, this is a feature. User code that does the
> >> same should also produce a warning. This is what warnings
> >> are for.
> > Shouldn't the test confirm that an int can be assigned to a
> > short in a variant and that the resulting short has the same
> > value as when the same int is assigned to a short not in a
> > variant? That test need not produce a warning because
> > comparing the results from the two assignments proves or
> > disproves the behavior of variant.
> Do you agree that getting a warning in this use case is a good
If the purpose of the test is to show that variant triggers the same warning as would an ordinary int-to-short assignment, getting the warning here is a good thing.
If the purpose of the test is to prove that assigning to variant has the same runtime behavior as non-variant code, as I suggested above, the warning is unwarranted noise.
Rob Stewart robert.stewart_at_[hidden]
Software Engineer, Core Software using std::disclaimer;
Susquehanna International Group, LLP http://www.sig.com
IMPORTANT: The information contained in this email and/or its attachments is confidential. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this message or any attachment by an unintended recipient is strictly prohibited. Neither this message nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this message or any of its attachments is free of viruses.
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk