Re: [boost] [new Warnings policy] MS C4180 on the Maintenance Guidelines

Subject: Re: [boost] [new Warnings policy] MS C4180 on the Maintenance Guidelines
From: Stewart, Robert (Robert.Stewart_at_[hidden])
Date: 2009-11-19 08:21:34

Paul A. Bristow wrote:
> Steven Watanabe wrote:
> > Emil Dotchevski wrote:
>
> > > Actually, prompted by compile error in Boost Exception on
> > > GCC 3.4.5,
> > > triggered by a warning "fix" made just prior to release (see
> > > http://svn.boost.org/trac/boost/ticket/3641) I think we
> > > should ban all
> > > last minute changes (including warning "fixes") that are not
> > > addressing *bugs*.
> >
> > +1.  Warnings should be suppressed, but fixing them isn't
> > worth the risk late in the release cycle.
>
> Definitely +1 more.

I agree with the caveat that suppressing, rather than fixing, for a release is appropriate, but that suppression should be removed and the warning should be addressed otherwise, if possible, after the release.

If a warning can be fixed by changing the code, and the result is reasonable and maintainable, and doesn't violate performance demands, then the warning should be eliminated by changing the code.  If those criteria cannot be met, then there should be assertions and/or tests that specifically address any issues raised by the warning to ensure that future platform alterations don't violate assumptions made by the code and flagged by the warning.  Only then should the warning be suppressed.

_____
Rob Stewart                           robert.stewart_at_[hidden]
Software Engineer, Core Software      using std::disclaimer;
Susquehanna International Group, LLP  http://www.sig.com

IMPORTANT: The information contained in this email and/or its attachments is confidential. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this message or any attachment by an unintended recipient is strictly prohibited. Neither this message nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this message or any of its attachments is free of viruses.