Subject: Re: [boost] [new Warnings policy] MS C4180 on the Maintenance Guidelines
From: Stewart, Robert (Robert.Stewart_at_[hidden])
Date: 2009-11-20 09:38:12
Emil Dotchevski wrote:
> On Thu, Nov 19, 2009 at 5:21 AM, Stewart, Robert
> <Robert.Stewart_at_[hidden]> wrote:
> > If a warning can be fixed by changing the code, and the result is
> > reasonable and maintainable, and doesn't violate performance
> > demands, then the warning should be eliminated by changing the
> > code.
> Two why questions:
> - why do you think that changing the code is better?
If the warning indicates a real issue in the code, suppressing the warning merely masks the problem. If not, then there's the issue of not being able to suppress the warning, as with GCC, or the additional line noise in the form of preprocessor directives or pragmas.
> - why do we care what action was taken to remove a warning?
I don't want problems hidden and I'd prefer that the code not have any more preprocessor/pragma line noise than required. Even if I'm not the maintainer, I know that reducing that line noise means that future changes will be easier for the maintainer.
Rob Stewart robert.stewart_at_[hidden]
Software Engineer, Core Software using std::disclaimer;
Susquehanna International Group, LLP http://www.sig.com
IMPORTANT: The information contained in this email and/or its attachments is confidential. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this message or any attachment by an unintended recipient is strictly prohibited. Neither this message nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this message or any of its attachments is free of viruses.
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk