Re: [boost] RFC: Sequence Properties and Boost Algorithm/Functional

Subject: Re: [boost] RFC: Sequence Properties and Boost Algorithm/Functional
From: Stewart, Robert (Robert.Stewart_at_[hidden])
Date: 2010-01-25 08:36:42

Marshall Clow wrote:
> On Jan 22, 2010, at 3:24 PM, Marshall Clow wrote:
> >
> > template<typename T>
> > bool is_strictly_increasing ( T* begin, T* end ) {
> > //  Empty sequences are strictly increasing
> >     if ( begin == end )
> >             return true;
> >
> >     T* iter = begin;
> >     T  val  = *iter++;
> >
> >     while ( iter != end ) {
> >             if ( ! ( *iter > val ))
> >                     return false;
> >             val = *iter++;
> >             }
> >     return true;
> >     }
>
> Three minutes after posting my code, I noticed that I worked
> all the comparisons to use ">" (and the code *does* work),
> rather than using "<" (or std::less), which is what I meant
> to do when I wrote this code.

On that subject, why not use std::iterator_traits<I>::value_type in your iterator version and eliminate the pointer specialization?

_____
Rob Stewart                           robert.stewart_at_[hidden]
Software Engineer, Core Software      using std::disclaimer;
Susquehanna International Group, LLP  http://www.sig.com

IMPORTANT: The information contained in this email and/or its attachments is confidential. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this message or any attachment by an unintended recipient is strictly prohibited. Neither this message nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this message or any of its attachments is free of viruses.