Re: [boost] Boost Graph library - r_c_shortest_paths

Subject: Re: [boost] Boost Graph library - r_c_shortest_paths
From: Jeremiah Willcock (jewillco_at_[hidden])
Date: 2010-02-22 21:10:47

On Mon, 22 Feb 2010, Andrew Sutton wrote:

(snip)

>> There's one less function and template parameter in the new version. I'm
>>> pretty sure we'd break something without a new name or module.
>>>
>>
>> Yes, most likely.  The full name resource_constrained_shortest_paths would
>> work, though, and fits with BGL conventions.
>>
>
> I like it, but I think the documentation sites an algorithm, which suggests
> to me that there might be others. Should we consider using the author's name
> in a module called resource_constrained_shortest_paths.hpp?

In that case, I think the author's name should be included.

>> One other issue I saw is that there are a bunch of loops like:
>>
>> for(int i = 0; i < static_cast<int>(num_vertices(g)); ++i)
>>
>
> I had planned to address these in a later pass. I'll go thru and and back
> out the smart pointer change (sort of) and start taking a closer looks at
> static_casts.

OK.

-- Jeremiah Willcock