Re: [boost] [utility/swap] MSVC 10 test failure, unsigned long to std::bitset conversion invalid?

Subject: Re: [boost] [utility/swap] MSVC 10 test failure, unsigned long to std::bitset conversion invalid?
From: Niels Dekker - address until 2010-10-10 (niels_address_until_2010-10-10_at_[hidden])
Date: 2010-03-07 16:53:22

On 2010-03-07 12:39, Joseph Gauterin wrote:
> [...] I'd be more inclined to mark the test as an expected
> failure on the MSVC10 than change the test itself.

[ I replied: ]
> Actually I have considered this approach as well, but I changed my mind.
> Because it's not the purpose of libs/utility/swap/test/std_bitset.cpp to
> test the initialization of an std::bitset. Its purpose is to test
> whether boost::swap correctly swaps two different std::bitset objects:
[...]
> How those initial_value1 and initial_value2 are actually initialized is
> irrelevant to the test. However, std_bitset.cpp should test whether
> boost::swap does the right thing, on any platform, including Microsoft
> Windows + VC 10.
>
> Hope you agree. But please let me know if you still object against the
> workaround, which just replaces "1ul" by "1", and "2ul" by "2":

So I just committed that little modification of std_bitset.cpp to the 
trunk: https://svn.boost.org/trac/boost/changeset/60331

My idea is just to look at the regression page for a week or so, to see 
if it doesn't cause any other test failures. Otherwise, we have to do 
something else...  Hope that sounds okay to you.

Kind regards,

   Niels

-- 
Niels Dekker
http://www.xs4all.nl/~nd/dekkerware
Scientific programmer at LKEB, Leiden University Medical Center