Re: [boost] New Boost.XInt Library, request preliminary review

Subject: Re: [boost] New Boost.XInt Library, request preliminary review
From: Chad Nelson (chad.thecomfychair_at_[hidden])
Date: 2010-03-26 18:55:45

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> I saw a couple of issues:
> * The operators should be defined in namespace xint, so they
>  will be found by ADL.

Done. I wasn't sure where they should go.

> * If you provide random functions, it should be as a specialization
>  of boost::uniform_int.  Ideally, however, boost::uniform_int would
>  just work.

I'm not familiar with that part of Boost.Random. I'm not sure how
xint::random_by_size could be properly mapped to it, though the other
three options could.

> random.cpp:80
>                std::transform(mString.begin(), mString.end(),
> mString.begin(),
>                    zero);
> this could be
> std::fill(mString.begin(), mString.end(), '\0');

Done, and thanks. I just grabbed the first thing that I knew.
- -- 
Chad Nelson
Oak Circle Software, Inc.
*
*
*
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkutO3EACgkQp9x9jeZ9/wTyrwCcDYw420BAMmpCW5SUUlLZsekR
NAgAoLSAcUgGef0fmdZaeQmmBdXroEJz
=Rpvz
-----END PGP SIGNATURE-----