Re: [boost] [units] gcc warnings

Subject: Re: [boost] [units] gcc warnings
From: Stewart, Robert (Robert.Stewart_at_[hidden])
Date: 2010-06-15 14:15:42

Steven Watanabe wrote:
> Stewart, Robert wrote:
> > Emil Dotchevski wrote:
> >> On Tue, Jun 15, 2010 at 3:55 AM, Stewart, Robert
> >> <Robert.Stewart_at_[hidden]> wrote:
> >>> Jürgen Hunold wrote:
> >>>
> >>>> I start using Boost.Units for a new project and found some
> >>>> annyoing warnings when compiling with "-Wall -Wextra" and
> >>>> "-Wconversion"
> >>>>
> >>>> Patch using an explicit static_cast<int> for the return value
> >>>> attached.
> >>>>
> >>> Do you know that the long int value can never exceed the
> >>> range of int?  If not, the static_cast will simply mask the
> >>> problem.
[snip more discussion]
>
> Humph.  Has anyone in this discussion actually looked at the
> code in question?

I didn't, but note that my reply merely calls on the OP to check whether the range of int will be exceeded.

> a) There can be no overflow because the possible values are
> enumerated.

That means the answer to my query would be affirmative, so the rest of the advice doesn't apply.

> b) With the current code, the compiler will implicitly use a
> static_cast.

Sure, but it does so noisily.

_____
Rob Stewart                           robert.stewart_at_[hidden]
Software Engineer, Core Software      using std::disclaimer;
Susquehanna International Group, LLP  http://www.sig.com

IMPORTANT: The information contained in this email and/or its attachments is confidential. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this message or any attachment by an unintended recipient is strictly prohibited. Neither this message nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this message or any of its attachments is free of viruses.