Boost logo

Boost :

Subject: Re: [boost] [gsoc] Boost.Process done
From: Jeff Flinn (TriumphSprint2000_at_[hidden])
Date: 2010-08-26 22:44:17


Jeff Flinn wrote:
> Boris Schaeling wrote:
>> Here are the results of the Boost.Process project within this year's
>
> Is this intended:
>
> boost/process/stream_behavior.hpp: line 117:
>
> return boost::make_shared<inherit>(inherit(child_end));

I see this is done in almost all uses of make_shared within boost::process.

> This is constructing an 'inherit' instance and passing it to
> make_shared, which I presume then calls the default copy constructor for
> inherit. Don't you mean:
>
> return boost::make_shared<inherit>(child_end);

Jeff


Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk