Subject: Re: [boost] [gsoc] Boost.Process done
From: Stewart, Robert (Robert.Stewart_at_[hidden])
Date: 2010-09-07 06:45:27
Boris Schaeling wrote:
> On Mon, 06 Sep 2010 03:07:26 +0200, Stewart, Robert
> <Robert.Stewart_at_[hidden]> wrote:
> >> Shall we use a bool to indicate whether an input or output
> >> stream is configured or something else like an enumeration? I
> >> think it all depends on how many developers want to define
> >> new stream behaviors and if it's worth to make the signature
> >> a bit more self-explanatory?
> > bool is never a good idea for such arguments, regardless of the
> > possibility of extending the set.
> It smells a bit like over-engineering to me but then I don't
> really mind to change it. More opinions?
As I noted in the snipped portion of my reply, why would anyone associate true (or false) with input and the other with output? bools are great when a value or argument is, itself, a Boolean quantity, but when they are used to represent non-Boolean quantities, there is no association possible beyond rote memorization.
Besides, removing doubt and adding clarity is hardly over-engineering.
Rob Stewart robert.stewart_at_[hidden]
Software Engineer, Core Software using std::disclaimer;
Susquehanna International Group, LLP http://www.sig.com
IMPORTANT: The information contained in this email and/or its attachments is confidential. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this message or any attachment by an unintended recipient is strictly prohibited. Neither this message nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this message or any of its attachments is free of viruses.