Subject: Re: [boost] [constrained_value] Constrained Value review results
From: Thorsten Ottosen (nesotto_at_[hidden])
Date: 2010-09-14 03:56:08
Den 14-09-2010 03:20, Robert Kawulak skrev:
>> From: Gordon Woodhull
>> All of the items in section 3 must be addressed at least in documentation. In some cases, they can
>> only be addressed that way ("Substitutability with the underlying type", "Constraints not copied when
>> operators used").
>> To my memory, no one asked for a second review, so it is my judgment that once Robert has addressed
>> section 3 the library can be released. Robert, please post any objections.
> You want to say literally all? I mean, some of the points were rather suggestions or minor requests (at least I felt so) or had no
> clear conclusion, e.g. "seralization" or "rename bounded_int", to name a few. For some of them I don't see how I could address them
> in documentation or why should they be crucial for final acceptance (don't get me wrong - I'm open for suggestions, but for instance
> if I were to add all the examples suggested by people to the docs, it would become too bloated and out of topic. A software
> maintainer can't do everything to please anybody but has to choose which requests to implement and which not to). To conclude - I
> don't feel section 3 contains only major issues, so should all of them be crucial for acceptance?
At least when it comes to naming, and possibly other issues, it is
customary to make a vote on the list to get some guideance and consensus.