Re: [boost] [Review] Formal Review of Proposed Boost.Ratio Library Starts TODAY

Subject: Re: [boost] [Review] Formal Review of Proposed Boost.Ratio Library Starts TODAY
From: Bruno Santos (bsantos_at_[hidden])
Date: 2010-10-04 16:15:29

Hi,

Here's my review. I don't think there's much to say about a tiny and
very wanted library.

> - What is your evaluation of the design?

The design is unquestionable since it follows the proposed C++0x one.
The provided IO extension is a valuable addition.

> - What is your evaluation of the implementation?

It's clear and robust.

> - What is your evaluation of the documentation?

The documentation is very complete. It provides a nice set of examples
on how to use it. And, some very important details provided by the
anexes "Rational" and "Implementation Notes".

> - What is your evaluation of the potential usefulness of the library?

Very useful on my domain, which is network protocols. I have to deal
with all sorts of time (and other) units.
And of course, Boost.Chrono needs it :-)

> - Did you try to use the library? With what compiler? Did you have any problems?

Yes. gcc, msvc and clang. No.

> - How much effort did you put into your evaluation? A glance? A quick
> - reading? In-depth study?

I've been following and using this library, so I'm familiar with it.
I did a quick reading at the documentation.

> - Are you knowledgeable about the problem domain?

Yes.

> - Do you think the library should be accepted as a Boost library?

Yes.