Re: [boost] [Review] Formal Review: Boost.Ratio

Subject: Re: [boost] [Review] Formal Review: Boost.Ratio
From: rbock_at_[hidden]
Date: 2010-10-06 03:16:25

"vicente.botet" <vicente.botet_at_[hidden]> hat am 5. Oktober 2010 um 23:10
geschrieben:

> >> - What is your evaluation of the implementation?
> >>Â  Â 
> > The code looks very clean, except for a few #if 0, which I would rather
> > have removed.
>
> I guess you are talking of these kind of #if 0
>
> #if 0
> public:
>     // The nested typedef type  shall be a synonym for ratio<R1::num *
>R2::den, R2::num * R1::den>::type.
>Â  Â  Â typedef typename ratio<R1::num * R2::den, R1::den * R2::num>::type type;
> #else
>
> You are right that these kind of comments could be more troubling that
> helping.
> What do you think about removing the #if 0 and letting the comment as follows?
>
> // The nested typedef type  is a synonym for ratio<R1::num * R2::den, R2::num
> * R1::den>::type that avoids overflows when possible. 
This is fine, IMO

>
> Thanks for helping me fixing warnings and for the many suggestion you did
> concerning the documentation.[...]
> And of course thanks for your positive review.

You're welcome! Thanks for the library :-)

Regards,

Roland