Re: [boost] [Boost-commit] svn:boost r66441 - in trunk/tools/build/v2: . engine/src engine/src/modules tools

Subject: Re: [boost] [Boost-commit] svn:boost r66441 - in trunk/tools/build/v2: . engine/src engine/src/modules tools
From: Bryce Lelbach (admin_at_[hidden])
Date: 2010-11-07 15:48:11

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sun, 7 Nov 2010 21:27:50 +0100
Jürgen Hunold <juergen.hunold_at_[hidden]> wrote:

> Hi !
> 
> On Sunday, 7. November 2010 20:51:11 admin_at_[hidden] wrote:
> > Modified: trunk/tools/build/v2/engine/src/modules/order.c
> > ===========================================================================
> > === --- trunk/tools/build/v2/engine/src/modules/order.c     (original) +++
> > trunk/tools/build/v2/engine/src/modules/order.c     2010-11-07 14:51:05
> > EST (Sun, 07 Nov 2010) @@ -50,8 +50,8 @@
> > 
> >          if (colors[adjacent_vertex] == white)
> >              do_ts(graph, adjacent_vertex, colors, result_ptr);
> > -        else if (colors[adjacent_vertex] == gray)
> > -            ; /* This is loop. Not sure what to do... */
> > +        //else if (colors[adjacent_vertex] == gray)
> > +            //; /* This is loop. Not sure what to do... */
> >      }
> >      colors[current_vertex] = black;
> >      **result_ptr = current_vertex;
> 
> Are you sure that you really wanted to commit this ?
> 
> Yours,
> 
> Jürgen

It's dead code. All it does is generate a warning with clang. The warning it
generates comes from the pass that eliminates dead code. There's a comment there
indicating that the original author was unsure what to do at that point. I left
the comment and the original condition for the sake of documentation.

- -- 
Bryce Lelbach aka wash
http://groups.google.com/group/ariel_devel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkzXEIsACgkQO/fqqIuE2t7AwQCfSWBso/iIOkz/RKoztV/wormn
5/UAnRchSZF7e1YSc03YrGgb5MK2M97X
=CH4O
-----END PGP SIGNATURE-----