Re: [boost] [python] [1.45] select_holder test failing

Subject: Re: [boost] [python] [1.45] select_holder test failing
From: Eric Niebler (eric_at_[hidden])
Date: 2010-11-15 21:03:18

On 11/15/2010 7:42 PM, Dave Abrahams wrote:
> On Mon, Nov 15, 2010 at 7:13 PM, Eric Niebler <eric_at_[hidden]> wrote:
>> (Please don't top-post. Re-arranging ...)
>>
>> On 11/15/2010 6:22 PM, Ralf W. Grosse-Kunstleve wrote:
>>> On November 9, 2010 4:28:04 PM, Eric Niebler wrote:
>>>> On 11/7/2010 5:17 PM, Eric Niebler wrote:
>>>>> Dave,
>>>>>
>>>>> The python "select_holder" test is failing across a large number
>>>>> of platforms on the release branch including all clang and gcc
>>>>> compilers. Can you please look into this prior to 1.45?
>>>>
>>>> This is  now ticket https://svn.boost.org/trac/boost/ticket/4829
>>>
>>> Hi Eric, I've fixed this on the trunk (svn rev. 66066). Let me know
>>> if you want me to merge the fix into the release branch.
>>> Ralf
>>
>> The revision you mention
>> (https://svn.boost.org/trac/boost/changeset/66066) does not point to a
>> commit to trunk.
>>
>> The release branch is closed to all but showstopper bugs. Ticket #4829
>> is not a showstopper, so any fix will not be taken, unless someone makes
>> a case for promoting #4829 to showstopper priority.
> 
> Well, it looks like that revision actually hit the release branch, so
> it's going to be up to you whether or not to roll it back.

[66066] was committed to release a month ago, before the branch was
frozen. It also hasn't fixed the test in question.

Ralf, did you mean [66606]? If getting these tests to pass is as simple
as adding a few missing include statements, I might consider taking this
fix. It's extremely low-risk.

> Ralf, thanks for your efforts!  There are other regressions in there I
> plan to tackle.

Seconded. Thanks,

-- 
Eric Niebler
BoostPro Computing
http://www.boostpro.com