Re: [boost] Formal Review of IO and Toolbox extensions to Boost.GIL starts TOMORROW

Subject: Re: [boost] Formal Review of IO and Toolbox extensions to Boost.GIL starts TOMORROW
From: Christian Henning (chhenning_at_[hidden])
Date: 2010-12-04 16:28:40

Hi Phil,

On Sat, Dec 4, 2010 at 12:13 PM, Phil Endecott
<spam_from_boost_dev_at_[hidden]> wrote:
> Christian Henning wrote:
>>
>> On Fri, Dec 3, 2010 at 1:54 PM, Phil Endecott wrote:
>>>
>>> Also, can you point out which images and tests exercise the error paths
>>> that
>>> we discussed at length (e.g. setjmp/longjmp) a few months ago?
>>
>> Every time you read/write a jpeg or a png you use the setjmp/longjmp
>> combination.
>
> Really?  My understanding was that longjmp is only called when there is an
> error.  Can you explain the code path that involves longjmp when a file is
> read or written successfully?
>

Sorry, there is a misunderstanding here. I should have clearer. For
instance, when reading a jpeg you set a mark with setjmp() see
read.hpp[49] in the jpeg folder. Just before that I set the error
handler "error_exit()" which will be called in case of an error. It's
only here that longjmp will be called. Though, you are correct in your
assumption that longjmp is only called when there is an error.

Hope you find some time to review my work.

Regards,
Christian