Re: [boost] [Review][Ratio] Boost.Ratio has been ACCEPTED

Subject: Re: [boost] [Review][Ratio] Boost.Ratio has been ACCEPTED
From: vicente.botet (vicente.botet_at_[hidden])
Date: 2011-01-01 09:09:03

Hi,
----- Original Message ----- 
From: "Anthony Williams" <anthony.ajw_at_[hidden]>
To: <boost_at_[hidden]>
Cc: <boost-announce_at_[hidden]>; <boost-users_at_[hidden]>
Sent: Friday, October 29, 2010 4:20 PM
Subject: [boost] [Review][Ratio] Boost.Ratio has been ACCEPTED

> 
> Hi,
> 
> I am pleased to announce that Boost.Ratio has been ACCEPTED into Boost.
> 
> A few changes were requested by the reviewers, which I will list
> below. I know that Vicente has already started working on some of
> these. These changes should be addressed before the library appears in a
> Boost release.
> 
> * Some of the macros had names with RATIO_RATIO in. These should be
>  changed to just RATIO
> 
> * The ratio_add, ratio_sub, ratio_multiply and ratio_divide templates
>  should derive from the resulting ratio type as well as providing the
>  nested ::type member, in order to closely emulate the template alias
>  facility from C++0x
> 
> * The typos in the documentation should be fixed, and the documentation
>  reviewed for correctness and clarity (though several of the reviewers
>  made positive comments on the quality of the documentation).
> 
> * The library needs more tests under the Boost Software License.
> 
> * All references to names from the boost namespace should be qualified
>  with boost:: to avoid potential name clashes and ambiguity with names
>  from the global namespace.
> 
> * Sections commented out with #if 0 should be removed
> 
> * The extensions beyond the facilities required by the C++0x draft
>  should be able to be enabled or disabled through use of a
>  configuration macro.
> 
> * References to the tests, examples and documentation from within the
>  code should be checked for correctness.

I've taken in account the requested changes. Paul Bristol is reviewing now the documentation, but he will prefer to fix some issues on trunk. 

I want to know if I can move to trunk now.

Thanks,
Vicente