Subject: Re: [boost] the <boost/detail/iomanip.hpp> header (please use it)
From: Dave Abrahams (dave_at_[hidden])
Date: 2011-01-14 16:48:51
At Fri, 14 Jan 2011 12:39:45 -0800,
Steven Watanabe wrote:
> On 1/14/2011 9:10 AM, Bryce Lelbach wrote:
> > On Fri, 14 Jan 2011 17:08:27 +0200
> > "Peter Dimov"<pdimov_at_[hidden]> wrote:
> >> Is this something that we really need to address? This problem has much
> >> wider scope than just Boost, and is of a temporary nature.
> > *shrugs*. Judgement call, really. There's two types of bugs in Boost - bugs
> > that we can fix without massive upheaveal/breaking other stuff, and bugs that
> > we can't. This falls into the category of easy and trivial to fix on our end, so
> > I did.
> Just because it's easy, doesn't mean it's the right
> thing to do. Your patch makes the code uglier,
> although not by much.
> You should also be more careful that you actually
> commit exactly what you intend to commit, especially
> with such widespread changes. In addition to the
> Jamfile changes which you noticed and reverted,
> you committed some workarounds for pathscale.
> I would not have approved those particular changes
> if they were for my library, simply because I really,
> *really* dislike scattering #ifdefs around.
This sounds problematic. Are these changes in trunk or release? If
in release, can they be pulled out until after the release, so we have
time to evaluate them, please?
-- Dave Abrahams BoostPro Computing http://www.boostpro.com