Re: [boost] [Boost-commit] svn:boost r67792 - in branches/release: boost/iterator

Subject: Re: [boost] [Boost-commit] svn:boost r67792 - in branches/release: boost/iterator
From: Marshall Clow (mclow.lists_at_[hidden])
Date: 2011-01-17 09:55:25

On Jan 17, 2011, at 5:16 AM, Michel MORIN wrote:

> Marshall Clow wrote:
>> On Jan 11, 2011, at 6:46 PM, Michel MORIN wrote:
>>> The log message says that the fixes for tickets #1427 and #2893
>>> (#1427: transform_iterator should use boost::result_of to determine
>>> functor result type)
>>> (#2893: Function Input Iterator)
>>> are merged to release.
>>> But this changeset does nothing with iterator/transform_iterator.hpp and
>>> iterator/function_input_iterator.hpp.
>> 
>> 
>> I merged several changes, and tried to figure out which tickets were affected by looking at svn log entries - and I got those two wrong :-(
> 
> Ah, I see ;-)
> Marshall, great thanks for your effort!
> 
> * Ticket #2893
> I reopened #2893 because function_input_iterator is not added to release yet.
> 
> 
> * Ticket #1427
> I also reopened #1427 because I found a bug in the updated code.
> transform_iterator should use 'result_of<UnaryFunc(Iterator::reference)>'
> but the code uses 'result_of<UnaryFunc(Iterator::reference)>'.
> 
> A patch is attached in #1427 which is extremely simple.
> Is there a chance that this will be fixed in Boost 1.46?

Michel - 

I've committed your patches to the trunk - thanks!

I don't think that they will be in 1.46, since I need to wait for the tests to cycle (which takes a couple days), and the deadline for merging stuff to release is _today_.

-- Marshall

Marshall Clow     Idio Software   <mailto:mclow.lists_at_[hidden]>

A.D. 1517: Martin Luther nails his 95 Theses to the church door and is promptly moderated down to (-1, Flamebait).
        -- Yu Suzuki