Boost logo

Boost :

Subject: [boost] [V1.46] [Iterator] Ask for release notes modification
From: Michel MORIN (mimomorin_at_[hidden])
Date: 2011-01-25 05:21:12


Hi,

I have some comments on the Boost 1.46 release notes for Boost.Iterator.
(http://svn.boost.org/svn/boost/website/public_html/beta/feed/history/boost_1_46_0.qbk)

Here are the release notes for Boost.Iterator:

  * fixed problem with `implicit_cast`
    ([@https://svn.boost.org/trac/boost/ticket/3645 #3645])
  * added `function_input_iterator`
    ([@https://svn.boost.org/trac/boost/ticket/2893 #2893])
  * `transform_iterator` now uses `boost::result_of` to determine
     functor result type
     ([@https://svn.boost.org/trac/boost/ticket/1427 #1427])

The first item seems OK :)

The second item needs to be deleted, since `function_input_iterator` is not
merged into release branch.

The third item also needs to be changed. As the release notes say,
`transform_iterator` now uses `boost::result_of` to determine
functor result type (in prior versions, it uses `result_type`).
But there is a bug: it should use `boost::result_of<Iterator::reference>` as
the documentation says, but it uses `boost::result_of<Iterator::value_type>`.
(This was fixed in trunk a week ago, but it was too late to merged to release.)
This bug makes subtle errors and confuses the users.
Is it better to mention the bug in the release notes explicitly?
Something like:

 * BUG: `transform_iterator` uses `boost::result_of<Iterator::value_type>` to
   determine functor result type instead of
`boost::result_of<Iterator::reference>`
    ([@https://svn.boost.org/trac/boost/ticket/1427 #1427])

Or simply delete this item?

Regards,
Michel


Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk