Re: [boost] Interest in a simple buffer abstraction?

Subject: Re: [boost] Interest in a simple buffer abstraction?
From: Stewart, Robert (Robert.Stewart_at_[hidden])
Date: 2011-01-27 14:44:59

Boris Kolpackov wrote:
> "Stewart, Robert" <Robert.Stewart_at_[hidden]> writes:
>
> > The idea has merit, but I wonder if an adaptor approach
> > would be better.
>
> This way I would have to write:
>
> class packet
> {
>   packet (void* data, size_t size)
>     : data_ (data_storage_, data, size)
>   {
>   }
>
>   std::vector data_storage_;

std::vector<char>, I presume.

>   boost::buffer data_;

Why would you have both?

> };

You either have this:

packet::packet(void const * _data, size_t _size)
   : data_storage_(static_cast<char const *>(_data),
        static_cast<char const *>(_data) + _size)
{
}

which means that the data is copied into data_storage_, or you have this:

packet::packet(boost::buffer & _buffer)
   : data_(_buffer)
{
}

which requires that some other code create a std::vector<char> or other container for the packet to use.  This, like any type erasing mechanism, isolates packet from the actual storage type.  The client can create a std::vector<char>, allocate an array of char on the stack, etc., and packet will work with them all.

_____
Rob Stewart                           robert.stewart_at_[hidden]
Software Engineer, Core Software      using std::disclaimer;
Susquehanna International Group, LLP  http://www.sig.com

IMPORTANT: The information contained in this email and/or its attachments is confidential. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this message or any attachment by an unintended recipient is strictly prohibited. Neither this message nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this message or any of its attachments is free of viruses.