Re: [boost] [spirit.phoenix] Phoenix test coverage

Subject: Re: [boost] [spirit.phoenix] Phoenix test coverage
From: Jim Bell (Jim_at_[hidden])
Date: 2011-02-08 22:02:08

On 1:59 PM, Joel de Guzman wrote:
> On 2/8/2011 11:50 AM, Jim Bell wrote:
>>
>>
>> On 1:59 PM, Hartmut Kaiser wrote:
>>>>> On 1:59 PM, Hartmut Kaiser wrote:
>>>>>> Tests for Phoenix V2 are not run at all, IIUC. This will change only
>>>>>> when/if Phoenix V3 has been moved to trunk after its mini-review.
>>>>>> The
>>>>>> tests you're referring to are Spirit specific tests using Phoenix
>>>>>> features.
>>>>> Looking at what's already released, libs/spirit/phoenix/test, I see
>>>>> what looks like a full suite of tests, and when I run bjam on them I
>>>>> get 45 tests passed (on MinGW gcc-4.4/win-32) and one failure.
>>>>>
>>>>> So the full compliment of tests is there and likely known to work
>>>>> on a
>>>>> couple platforms, just not run by the regression mechanism.
>>>>>
>>>>> [...]
>>>> We know about this bug and it is quite embarrassing ... It is
>>>> actually a
>>>> bug in the testcase itself :) I will take care of it ASAP.
>>
>> Your vindication far outweighs this little embarrassment: your tests are
>> there, seem comprehensive, and pass. I'd love to see them be part of the
>> regular regression run, but I've seen enough to have confidence in it.
>
> It's my fault actually. Thanks Thomas and Hartmut!

With that commit, all 46 tests pass on MinGW gcc-4.4/Win-32. (Curiously,
bjam ends with "...failed updating 1 target..." but I see no failures.)

Cheers!
-Jim