Re: [boost] [Review] Boost.Type Traits Extension by Frederic Bron

Subject: Re: [boost] [Review] Boost.Type Traits Extension by Frederic Bron
From: Jeffrey Lee Hellrung, Jr. (jhellrung_at_[hidden])
Date: 2011-03-15 09:21:04

On 3/15/2011 1:46 AM, Frédéric Bron wrote:
>> * shift operator could be named bit_left/right_shift
>
> But this would let think that this operator operates only on integers
> which is wrong as it already operates with std::ostream std::istream
> from the standard library.

I, too, prefer shift_left and shift_right, given their ubiquity related 
to std::iostream.

>> * has_operator_complement could be has_operator_bit_not
>
> Same comment although there is no class from the standard library that
> defines this operator, right? but user classes could.

+1 for complement, although it's not a strong preference over bit_not.

>> * prefix_ could be pre_ and suffix_ could be post_ (e.g. pre_increment and
>> post_increment)
>
> I have no issue with that.

+1 for pre_increment etc.

- Jeff